Fix allocations introduced in step
#454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
commented
Jun 8, 2025
| # Remove undef | ||
| if FullTraj | ||
| res = res[isassigned.(Ref(res), 1:n_steps)] | ||
| resize!(res, i) |
Member
Author
There was a problem hiding this comment.
It seemed a bit useless to compute the not-undefed entries if we already know that exactly entries 1 to i are assigned some value.
Collaborator
There was a problem hiding this comment.
Good catch! The resize is better than the previous one.
Contributor
|
AdvancedHMC.jl documentation for PR #454 is available at: |
ErikQQY
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the unnecessary allocation introduced in #431 (see https://github.com/TuringLang/AdvancedHMC.jl/pull/431/files#r2128763944). I could have just reverted to the state prior to #431 but I felt that it would be cleaner to just not use
resat all in the casefullTraj = false.