Skip to content

Mock response seems to be not executed when calling non-base version of OAS API #7254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Mock response seems to be not executed when calling non-base version of OAS API #7254

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc8c37c
OAS api versions performing fixes
radkrawczyk Jul 25, 2025
d4d0f57
if condifion for classic api
radkrawczyk Jul 28, 2025
848b2db
fixes
radkrawczyk Jul 29, 2025
af51ff4
cleanup
radkrawczyk Aug 4, 2025
ab0427e
cleanup
radkrawczyk Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion gateway/mw_version_check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package gateway
import (
"errors"
"net/http"
"net/url"
"time"

"github.com/getkin/kin-openapi/routers"
Expand Down Expand Up @@ -89,7 +90,22 @@ func (v *VersionCheck) ProcessRequest(w http.ResponseWriter, r *http.Request, _
}
}

v.Spec.SanitizeProxyPaths(r)
if v.Spec.IsOAS {
targetApi, ok := v.Gw.apisByID[subVersionID]

if !ok {
return errors.New(string(VersionDoesNotExist)), http.StatusNotFound
}

strippedPath := v.Spec.StripListenPath(r.URL.Path)
newPath, err := url.JoinPath(targetApi.Proxy.ListenPath, strippedPath)
if err != nil {
return err, http.StatusInternalServerError
}
r.URL.Path = newPath
} else {
v.Spec.SanitizeProxyPaths(r)
}

handler.ServeHTTP(w, r)
return nil, middleware.StatusRespond
Expand Down
Loading