Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/deploy-aws.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,3 @@ jobs:
AWS_ASSETS_BUCKET: 'typeform-public-assets/embed'
AWS_CLOUDFRONT_DIST: 'E3IUO95IYL1RI3'
PUBLIC_CDN_URL: 'https://embed.typeform.com'

- uses: 8398a7/action-slack@v3
if: failure()
with:
status: ${{ job.status }}
fields: repo,message,commit,author,action
env:
SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}
2 changes: 1 addition & 1 deletion packages/embed/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ yarn
We recommend you work in a branch:

```bash
git checkout -b cool-new-feature
git checkout -b my-cool-new-feature
```

Build, watch for changes and start a demo server too (using `demo-nextjs`)
Expand Down
8 changes: 4 additions & 4 deletions scripts/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ yarn release-vanilla

# bump embed in embed-react
echo "-- bump embed in embed-react"
EMBED_VERSION=$(npm view @typeform/embed version)
EMBED_VERSION=$(node -p "require('$REPO_ROOT/packages/embed/package.json').version")
echo "Latest @typeform/embed version: $EMBED_VERSION"
cd $REPO_ROOT/packages/embed-react
sed -i.bak "s/\"@typeform\/embed\": \".*\"/\"@typeform\/embed\": \"$EMBED_VERSION\"/" package.json && rm package.json.bak
Expand All @@ -36,16 +36,16 @@ yarn release

# bump embed and embed-react in demos
echo "-- bump embed and embed-react in demos"
EMBED_VERSION=$(npm view @typeform/embed version)
EMBED_REACT_VERSION=$(npm view @typeform/embed-react version)
EMBED_VERSION=$(node -p "require('$REPO_ROOT/packages/embed/package.json').version")
EMBED_REACT_VERSION=$(node -p "require('$REPO_ROOT/packages/embed-react/package.json').version")
echo "Latest @typeform/embed version: $EMBED_VERSION"
echo "Latest @typeform/embed-react version: $EMBED_REACT_VERSION"
cd $REPO_ROOT/packages/demo-nextjs
sed -i.bak "s/\"@typeform\/embed\": \".*\"/\"@typeform\/embed\": \"$EMBED_VERSION\"/" package.json && rm package.json.bak
sed -i.bak "s/\"@typeform\/embed-react\": \".*\"/\"@typeform\/embed-react\": \"$EMBED_REACT_VERSION\"/" package.json && rm package.json.bak

# commit embed and embed-react bumps in demo-nextjs
echo "-- commit embed and embed-react bumps in demp-nextjs"
echo "-- commit embed and embed-react bumps in demo-nextjs"
cd $REPO_ROOT
git add packages/demo-nextjs
git commit -m 'chore: Bump @typeform/embed and @typeform/embed-react in demo-nextjs'
Expand Down
Loading