Add language/title in track selection#506
Draft
moi15moi wants to merge 1 commit intoTypesettingTools:masterfrom
Draft
Add language/title in track selection#506moi15moi wants to merge 1 commit intoTypesettingTools:masterfrom
moi15moi wants to merge 1 commit intoTypesettingTools:masterfrom
Conversation
Member
|
I know it's still a draft, but if the upstream PR is merged this will still need an ifdef for the ffms2 version - this is also why the CI fails on Linux. |
moi15moi
force-pushed
the
Add-language/title-in-track-selection
branch
from
182f0ce to
f3f252f
Compare
Contributor
Author
|
@arch1t3cht Currently, this PR use this syntax Do you believe I should add the channel count as requested in arch1t3cht#171 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a draft because i'm waiting for FFMS/ffms2#467 to be merged.
Note that ffmpeg doesn't expose the BCP language of mkv file (see: https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21257). There might be a day a new field named
language_bcp.Before
Video track
Audio track
Now
Video track
Audio track
