Draft
Conversation
Member
|
I haven't looked at the code yet, but one note upfront: wxWidgets generally advises against using FromDIP in their docs and instead recommends using text measurements instead:
Of course FromDIP is not forbidden and is fine to use for e.g. Aegisub's initial window size, but if a size can be reasonably computed using text extents (like column widths in a table) that is strongly preferred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expect this PR will eventually be composed with these commits:
sizer->Add(...)where a positive border width was specified, but the border direction was not specified;sizer->Add(...)where the border direction was specified, but the border width is set to 0;sizer->Add(...)where both Center and Expand were used;sizer->Add(...);wxSizerFlags().Border()for implicit Hi-DPI managementsizer->Add()withwxSizerFlags().Border()familywxSizerFlags()FromDIPfor Hi-DPI supportwxSize(-1, -1)with wxDefaultSizewxSize(a, b)andSetSize(a, b)withFromDIPFromDIP, in allCreate/Append/Insertcolumns