Conversation
This is largely a copy-paste of the (old) QuadraticPrior class. This needs to be refactored.
Collaborator
Author
|
@ashgillman possibly this is helpful, but probably not... |
| template <> | ||
| const char * const | ||
| QuadraticBowsherPrior<float>::registered_name = | ||
| "NewAnatomical"; |
Collaborator
There was a problem hiding this comment.
Just having a look. But why "NewAnatomical" and not just "Bowsher"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR currently contains my 2017 quick attempt to create a Bowsher prior. This is largely a copy-paste of the
QuadraticPrior, which is very bad practice...This PR currently only exists to help someone who wants to implement the Bowsher. It probably doesn't even compile anymore!
@tsai-yujung tried it at the time and as far as I recall found problems with it.