-
Notifications
You must be signed in to change notification settings - Fork 0
Noah/Barometer_Drivers #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| constexpr int CMD_TIMEOUT = 150; | ||
|
|
||
| // Barometer Commands (should not be modified, non-const due to HAL and C++ strictness) | ||
| static uint8_t ADC_D1_512_CONV_CMD = 0x42; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason these are static? Can they not be constexpr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HAL freaks out if they are const, although they should not be changed.
| constexpr int CMD_TIMEOUT = 150; | ||
|
|
||
| // Barometer Commands (should not be modified, non-const due to HAL and C++ strictness) | ||
| static uint8_t ADC_D1_512_CONV_CMD = 0x42; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here, I believe these can be made constexpr.
Created the drivers for MS5611 and MS5607 Barometers
To test:
To integrate: