falco in progress not tested ripped from notes#107
Open
rohan-ap457 wants to merge 6 commits intomainfrom
Open
Conversation
ChrisM09
requested changes
Jan 12, 2025
Contributor
ChrisM09
left a comment
There was a problem hiding this comment.
Few major things that need to be done:
- Must be tested on both a standalone system and a working K8s cluster. Otherwise, it could cause a lot of confusion.
- A description on what Falco is needed. Link to another README that does this as well.
- No description on how to use these Ansible playbooks on a system.
- Any considerations when deploying this?
- Use code blocks for quick copy and pasting.
There are more, but you get the point.
made bash scripts from the yaml's and these didnt not break the graylog test machines. will have to test on other systems and services
viktor dashboard
DaintyJet
requested changes
Jan 21, 2025
Contributor
DaintyJet
left a comment
There was a problem hiding this comment.
You put the bash scripts into the ansible folder?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of Changes
General overview of what has been changed
Reason for Modification
This section will list the reasons modification were preformed. This justifies why the changes are necessary or the documentation should be added.
Verification
Images.