Open
Conversation
DaintyJet
requested changes
Oct 8, 2024
Contributor
DaintyJet
left a comment
There was a problem hiding this comment.
The only file that is included in the commit is the old PDF.
rohan-ap457
commented
Oct 8, 2024
DaintyJet
requested changes
Oct 8, 2024
Contributor
DaintyJet
left a comment
There was a problem hiding this comment.
The old PDF should probably be deleted.
Also the new Markdown should be placed into the K8s folder.
On your branch this would be: https://github.com/UML-Cyber-Security/CCDC_Practice_Infrastructure/tree/rohan-ap457-patch-1/OperatingSystem-Services/Service-Containers/Kubernetes
Contributor
|
Otherwise seemed fine to me. Chris likes Images but I am fine with, or without. |
…mple_installtion_wiht_flannel_as_cni.pdf deleted this
…tem-Services/Service-Containers/Kubernetes/kubernetes_installation_with_flannel_as_cni.md updated location of file
Author
|
done all except images |
Contributor
|
Are there supposed to be images @rohan-ap457 , if so, I don't see any. |
Author
|
i did not have an screenshots to go with it |
Falco in progress need to finish. was ripped from notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of Changes
General overview of what has been changed
Reason for Modification
This section will list the reasons modification were preformed. This justifies why the changes are necessary or the documentation should be added.
Verification
Images.