updated prefixsum #285
Open
updated prefixsum #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasiddique
reviewed
May 19, 2025
Comment on lines
+226
to
+227
| for (uint64_t i = 0; i < input.size(); i++) { | ||
| hostoutput[i + 1] = hostoutput[i] + input[i + 1]; |
There was a problem hiding this comment.
This is an out-of-bounds access. Depending on the compiler and operating system, it may either get segmentation fault, or produce error-prone results.
There was a problem hiding this comment.
prefix-sum.out(9981,0x1f217cf40) malloc: Incorrect checksum for freed object 0x12200c800: probably modified after being freed.
Corrupt value: 0xffc00
prefix-sum.out(9981,0x1f217cf40) malloc: *** set a breakpoint in malloc_error_break to debug
Abort trap: 6
fasiddique
reviewed
May 19, 2025
Comment on lines
+239
to
+244
| for (uint64_t i = 0; i < intermeadiate_results.size(); ++i) { | ||
| if (i % 2 == 0) | ||
| even.push_back(intermeadiate_results[i]); | ||
| else | ||
| odd.push_back(intermeadiate_results[i]); | ||
| } |
There was a problem hiding this comment.
It's recommended to avoid using push_back for efficiency purpose, because this allocates memory dynamically. Since the vector size is known beforehand, we can use reside and indexing.
fasiddique
reviewed
May 19, 2025
Comment on lines
+228
to
+229
| intermeadiate_results.push_back(input[i]); | ||
| host_device_merged.push_back(input[i]); |
There was a problem hiding this comment.
Why do we need to have three copies of the input vector?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please the updated version.