-
Notifications
You must be signed in to change notification settings - Fork 18
[ISSUE-262, 85] Unfix the Compute Capabilities across CMakeLists, NVCC Compiler Options #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stardriftfx
wants to merge
5
commits into
SharedDevelopment
Choose a base branch
from
262-unfix-the-compute-capabilities-across-cmakelists
base: SharedDevelopment
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7dc42dd
- updated nvcc compile flag to compile on local machine, if target no…
stardriftfx ed0faa7
Potential fix for pull request finding
stardriftfx 0ff39e9
Apply suggestions from code review
stardriftfx 9747fce
cuda enabled (not sure if this didnt get sent)
stardriftfx e9294d8
Merge branch '262-unfix-the-compute-capabilities-across-cmakelists' o…
stardriftfx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # GPU Architecture Levels | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't appear to be linked in to the documentation. |
||
| Originally, Graphitti used CUDA Compute Capability (CC 3.5). This later changed to use a flexible architecture model, such that Graphitti can now be compiled for modern hardware (such as Volta or Lovelace). This allows the simulator to leverage modern GPU features while maintaining backwards compatibility for older cards by using conditional compilation. | ||
|
|
||
| # Supported Architectures | ||
|
|
||
| | Architecture | Compute Capability | Project Build Compatibility | | ||
| | :--- | :--- | :--- | | ||
| | **Kepler** | 3.5 / 3.7 | **Baseline**: Minimum version for backwards compatibility. | | ||
| | **Volta** | 7.0 | **Target**: Primary architecture for high-performance server runs. | | ||
| | **Ampere** | 8.0 / 8.6 | **Development**: Common for modern local development. | | ||
| | **Ada Lovelace**| 8.9 | **Current**: Latest generation available in the lab. | | ||
|
|
||
| ## Compute Capability | ||
| * Binary Compatibility (cubin): Strictly backwards compatible. A binary for raiju (3.7) runs on ghidorah (8.9), but not vice versa. | ||
| - Backwards Compatibility: Any code compiled on an older architecture will work on newer ones. | ||
|
|
||
| - Forwards Compatibility (PTX): Any code compiled for a specific architecture will require that or a newer one to run. | ||
| - Parallel Thread Execution (PTX): PTX is included in lab builds. | ||
stardriftfx marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Specifying Target Architecture | ||
|
|
||
| By default, if not user-specified, `TARGET_ARCH` is set to `"native"` | ||
| which auto-detects and utilizes local hardware. | ||
|
|
||
| Legacy Support: -DTARGET_ARCH=35 | ||
|
|
||
| Otachi Server: -DTARGET_ARCH=70 | ||
|
|
||
| # Performance Notes | ||
| ## Lab Servers Reference Table | ||
| Info retrieved from `nvidia-smi` (in terminal). | ||
|
|
||
| | Lab Server | GPU Model | Architecture | Compute Capability | Recommended `TARGET_ARCH` | | ||
| | :--- | :--- | :--- | :--- | :--- | | ||
| | **raiju** | Tesla K80 | **Kepler** | 3.7 | `37` | | ||
| | **otachi** | Tesla V100-PCIE-16GB | **Volta** | 7.0 | `70` | | ||
| | **ghidorah** | RTX 4500 Ada Generation | **Ada Lovelace** | 8.9 | `89` | | ||
|
|
||
| Note: Per project guidelines, conditional compilation adds structural complexity (code cruft). We only implement architecture-specific paths if they produce a measurable benefit. | ||
|
|
||
| - Example: Run a 5-10 minute simulation and then measure performance `nvidia-smi` and compare it to baseline results. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed successfully though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generates worrisome warnings that don't exist previously: