-
Notifications
You must be signed in to change notification settings - Fork 45
Zonal Avg Notebook Update #1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… a try/except so that if a caller passes a dimension name that doesn’t exist then raise ValueError; test case for the same
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
erogluorhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the overall update on the notebook aiming at (to better know how I should review it)?
|
@rljacob mentioned that if we include a 2D example, it would serve as the good practical use-case for zonal mean/average notebook. |
|
View / edit / reply to this conversation on ReviewNB erogluorhan commented on 2025-11-20T14:18:35Z
|
|
View / edit / reply to this conversation on ReviewNB erogluorhan commented on 2025-11-20T14:18:36Z Change the first sentence to "The non-conservative method samples face values at specific lines of constant latitude and calculates the average, weighting those values with the line of intersection between each face and the latitude." |
|
View / edit / reply to this conversation on ReviewNB erogluorhan commented on 2025-11-20T14:18:37Z Change a sentence to "...averaging the native face values with intersection line (non-conservative) or area (conservative) weights..."
Change another sentence to "unlike a cross section that interpolates to create a 2D output over a single path" |
|
View / edit / reply to this conversation on ReviewNB erogluorhan commented on 2025-11-20T14:18:37Z Instead of repeating the details of zonal mean in this tip, how about something like this:
"Instead of " |
erogluorhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; thanks very much!
Also, some error check