Skip to content

Conversation

@rajeeja
Copy link
Contributor

@rajeeja rajeeja commented Dec 16, 2025

  • _icon_to_ugrid_dims now derives the mapping from the actual ICON coords and connectivity (including nv→n_max_face_nodes, nc→two, etc.), and falls back to common names.
  • With the full map, _map_dims_to_ugrid cleanly swaps all ICON dims to UGRID for both grid and data, so face coords are consistently normalized. When cross_section rewrites the lon/lat coord keys to the new steps dimension, there’s no leftover clon/clat tied to n_face, and validation passes.

This makes ICON I/O robust across variants and preventing future coord/dim mismatches.

Fixes #1425

@tdoerff please verify.

Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we are still having the same issues with cross-sections on the dataset @tdoerff provided through this branch. I am debugging your changes.

@erogluorhan erogluorhan self-requested a review December 17, 2025 18:39
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've re-run link-check that failed. Once it passes, we can merge this

@erogluorhan erogluorhan merged commit 7e1c311 into main Dec 17, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Naming conflicts on cross_section for ICON grids

4 participants