Skip to content

[796] FIX: Containers status is not updated when a new commit is bein… #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[796] FIX: Containers status is not updated when a new commit is bein… #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68c1e79
[796] FIX: Containers status is not updated when a new commit is bein…
zipofar Feb 21, 2023
85de29b
[796] refactor
zipofar Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions internal/domain_logic/network_connectivity/templates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ type ConnectivityContainerStatus struct {
DomainName string `json:"domain_name,omitempty"`
Port int `json:"port"`
Status ConnectivityStatus `json:"status"`
Version string `json:"version"`
}

type ConnectivityContainer struct {
Expand Down Expand Up @@ -56,6 +57,7 @@ func NewNetworkConnectivityTemplate(containerList domainTypes.ContainerList) (*C
DomainName: domainName,
Port: containerPort,
Status: StatusPending,
Version: container.Version,
},
}

Expand All @@ -69,8 +71,9 @@ func (response *ConnectivityResponse) AddIngressContainer(container *domainTypes
containerID := fmt.Sprint(container.ID)
networkConnectivityContainer := response.Containers[containerID]
networkConnectivityContainer.Ingress = &ConnectivityContainerStatus{
Port: global.Settings.IngressDefaultPort,
Status: StatusPending,
Port: global.Settings.IngressDefaultPort,
Status: StatusPending,
Version: container.Version,
}

response.Containers[containerID] = networkConnectivityContainer
Expand Down
1 change: 1 addition & 0 deletions internal/types/domain/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ type Container struct {
ServiceName string `json:"service_name"`
AdditionalSubdomains []string `json:"additional_subdomains"`
ContainerHostVolumeFiles []*ContainerHostVolumeFile `json:"container_host_volume_files"`
Version string `json:"version"`
}

func (c Container) IsPublic() bool {
Expand Down