ExpressionCompiler: Location compatible expressions should use only implicit cast, to cover implicit cast operators (STUD-78703) #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR modifies the expression compiler to use explicit cast operators instead of safe cast operators (the as keyword) for location-compatible expressions. This change enables support for user-defined implicit cast operators, which are not invoked by the as operator but are properly handled by explicit cast syntax.
Changes:
- Simplified
FormatWithTypeCastto always use explicit cast syntax instead of conditionally choosing between safe cast and explicit cast - Removed helper methods
CanUseSafeCastOperator,SafeCastText, andIsNullableValueTypethat are no longer needed - Added defensive null/empty check for expression text in
FormatWithTypeCast
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…mplicit cast, to cover implicit cast operators (STUD-78703)
gpanaitescu
force-pushed
the
fix/implicit_cast_operator_for_expressioncompiler
branch
from
96ba045 to
19c16a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://uipath.atlassian.net/browse/STUD-78703