Skip to content

Conversation

@thecristidima
Copy link

@thecristidima thecristidima commented Jan 15, 2026

The upgrade from 2.5 to 3.16 included some log changes that we were
filtering. This caused Robot logs to be filled with spammy logs after
the upgrade.

The logs in question are:

"transport_check_fds: transport->ReceiveCallback() - STATE_RUN_FAILED"

This log would return an int on some fast path, it's now changed to a
string.

2.5 -

if (!update_end_paint(update))

3.16 - https://github.com/FreeRDP/FreeRDP/blob/969235f7cfb6778306f362be53507326ab0ef867/libfreerdp/core/fastpath.c#L657

"CONNECTION_STATE_ACTIVE status STATE_RUN_FAILED [-1]"

This log is missing from 2.5.

2.5 -

return status;

3.16 - https://github.com/FreeRDP/FreeRDP/blob/fcdf4c6c7e7ffda9203889114a2ee7ba8d5d1976/libfreerdp/core/rdp.c#L2180

"Secondary Drawing Order [0x"

2.5 -

WLog_Print(update->log, WLOG_ERROR, "SECONDARY ORDER %s failed", name);

3.16 - https://github.com/FreeRDP/FreeRDP/blob/fcdf4c6c7e7ffda9203889114a2ee7ba8d5d1976/libfreerdp/core/orders.c#L4253

"Primary Drawing Order"

This one was changed from warning to error

2.5 -

WLog_Print(update->log, WLOG_WARN, "Primary Drawing Order %s failed", orderName);

3.16 - https://github.com/FreeRDP/FreeRDP/blob/fcdf4c6c7e7ffda9203889114a2ee7ba8d5d1976/libfreerdp/core/orders.c#L4072

Also ignored three more warning logs - two show up during connect and is
related to a compile flag that wasn't used.

The upgrade from 2.5 to 3.16 included some log changes that we were
filtering. This caused Robot logs to be filled with spammy logs after
the upgrade.

The logs in question are:

"transport_check_fds: transport->ReceiveCallback() - STATE_RUN_FAILED"

This log would return an int on some fast path, it's now changed to a
string.

2.5 - https://github.com/UiPath/FreeRDP/blob/201e456468863dacf29e270f75d2f59325df667a/libfreerdp/core/fastpath.c#L669
3.16 - https://github.com/FreeRDP/FreeRDP/blob/969235f7cfb6778306f362be53507326ab0ef867/libfreerdp/core/fastpath.c#L657

"CONNECTION_STATE_ACTIVE status STATE_RUN_FAILED [-1]"

This log is missing from 2.5.

2.5 - https://github.com/UiPath/FreeRDP/blob/201e456468863dacf29e270f75d2f59325df667a/libfreerdp/core/rdp.c#L1679
3.16 - https://github.com/FreeRDP/FreeRDP/blob/fcdf4c6c7e7ffda9203889114a2ee7ba8d5d1976/libfreerdp/core/rdp.c#L2180

"Secondary Drawing Order [0x"

2.5 - https://github.com/UiPath/FreeRDP/blob/201e456468863dacf29e270f75d2f59325df667a/libfreerdp/core/orders.c#L3916
3.16 - https://github.com/FreeRDP/FreeRDP/blob/fcdf4c6c7e7ffda9203889114a2ee7ba8d5d1976/libfreerdp/core/orders.c#L4253

"Primary Drawing Order"

This one was changed from warning to error

2.5 - https://github.com/UiPath/FreeRDP/blob/201e456468863dacf29e270f75d2f59325df667a/libfreerdp/core/orders.c#L3746
3.16 - https://github.com/FreeRDP/FreeRDP/blob/fcdf4c6c7e7ffda9203889114a2ee7ba8d5d1976/libfreerdp/core/orders.c#L4072

Also ignored three more warning logs - two show up during connect and is
related to a compile flag that wasn't used.
@thecristidima thecristidima force-pushed the fix/update_log_filters branch from 8a437f2 to eb102a1 Compare January 15, 2026 11:19
@thecristidima thecristidima changed the title Fix/update log filters Update FreeRDP log filters ROBO-5260 Jan 15, 2026
@thecristidima thecristidima marked this pull request as ready for review January 15, 2026 14:43
@thecristidima
Copy link
Author

Published UiPath.FreeRdpClient.24.2.0-20260115-03-dev and ran Robot-Endurance-Session and CI-Robot-Session to validate the logs no longer show up.

@mihainradu mihainradu merged commit c53dc74 into uipath-3.16 Jan 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants