Update FreeRDP log filters ROBO-5260 #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade from 2.5 to 3.16 included some log changes that we were
filtering. This caused Robot logs to be filled with spammy logs after
the upgrade.
The logs in question are:
"transport_check_fds: transport->ReceiveCallback() - STATE_RUN_FAILED"
This log would return an int on some fast path, it's now changed to a
string.
2.5 -
FreeRDP/libfreerdp/core/fastpath.c
Line 669 in 201e456
3.16 - https://github.com/FreeRDP/FreeRDP/blob/969235f7cfb6778306f362be53507326ab0ef867/libfreerdp/core/fastpath.c#L657
"CONNECTION_STATE_ACTIVE status STATE_RUN_FAILED [-1]"
This log is missing from 2.5.
2.5 -
FreeRDP/libfreerdp/core/rdp.c
Line 1679 in 201e456
3.16 - https://github.com/FreeRDP/FreeRDP/blob/fcdf4c6c7e7ffda9203889114a2ee7ba8d5d1976/libfreerdp/core/rdp.c#L2180
"Secondary Drawing Order [0x"
2.5 -
FreeRDP/libfreerdp/core/orders.c
Line 3916 in 201e456
3.16 - https://github.com/FreeRDP/FreeRDP/blob/fcdf4c6c7e7ffda9203889114a2ee7ba8d5d1976/libfreerdp/core/orders.c#L4253
"Primary Drawing Order"
This one was changed from warning to error
2.5 -
FreeRDP/libfreerdp/core/orders.c
Line 3746 in 201e456
3.16 - https://github.com/FreeRDP/FreeRDP/blob/fcdf4c6c7e7ffda9203889114a2ee7ba8d5d1976/libfreerdp/core/orders.c#L4072
Also ignored three more warning logs - two show up during connect and is
related to a compile flag that wasn't used.