Skip to content

Conversation

@ionmincu
Copy link
Contributor

@ionmincu ionmincu commented Jan 16, 2026

Development Package

  • Use uipath pack --nolock to get the latest dev build from this PR (requires version range).
  • Add this package as a dependency in your pyproject.toml:
[project]
dependencies = [
  # Exact version:
  "uipath==2.5.5.dev1011383948",

  # Any version from PR
  "uipath>=2.5.5.dev1011380000,<2.5.5.dev1011390000"
]

[[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
publish-url = "https://test.pypi.org/legacy/"
explicit = true

[tool.uv.sources]
uipath = { index = "testpypi" }

[tool.uv]
override-dependencies = [
    "uipath>=2.5.5.dev1011380000,<2.5.5.dev1011390000",
]

@ionmincu ionmincu self-assigned this Jan 16, 2026
@ionmincu ionmincu added the build:dev Create a dev build from the pr label Jan 16, 2026
@github-actions github-actions bot added test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository labels Jan 16, 2026
@cristipufu cristipufu requested a review from akshaylive January 17, 2026 08:50
@cristipufu
Copy link
Member

Copy link
Collaborator

@akshaylive akshaylive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary? I added some that are NonRecording to the trace and they don't even hit this method. Additionally. the inheritance structure of ReadableSpan and NonRecordingSpans are incompatible, so the argument definition on L407 should be updated.

Please share an example where this change is necessary, and please add some unit tests that reflect the scenario.

try:
dict_spans = [span.to_json(indent=None) for span in spans]
# Filter out NonRecordingSpan instances
recording_spans = [s for s in spans if not isinstance(s, NonRecordingSpan)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be

[s for s in spans if not self._should_drop_span(s)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build:dev Create a dev build from the pr test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants