Conversation
dd3010c to
cbd64db
Compare
|
is this still relevant on the dev branch with the dynamic spi settings? i apologize for the broken history, you probably have to rebase to check what is already changed |
As far as I can tell, this PR still sets up edges and polarity in a different way than the other modes. I only saw changes to the speed settings in recent commits but it's more than likely that I missed something. |
|
Yes it is a valid mode but i am thinking about a better way to name it. rp2040 doesn't make much sense to a user if it is not clear what the spi settings are also considering that it is with positive CS polarity which is unusual. Maybe we could rename all the modes like "DIY Mode CS+,CL+" or something. |
Add an SPI_BtnMode for the RP2040.
Opened in draft as I can't figure out why the OpenFFBoard still boots into TM-mode if RP2040 mode was saved to flash.#160 has been opened if this isn't the place for spitting ideas.
Edit: Turns out that
restoreFlash()runssetConfig()which in turn runsinitSPI(), only for theSPI_Buttonsconstructor to change some of the SPI port values and re-runinitSPI(). 7cbcb08 fixes this behavior, published separately in #164.