[pull] main from hoppscotch:main #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neously (#5605) Co-authored-by: nivedin <[email protected]>
Bump dependencies and account for breaking changes. --------- Co-authored-by: James George <[email protected]>
This updates Hoppscotch Agent dependencies to align with `v2025.11.0` security patch and other dependency chain.
This updates Hoppscotch Desktop (Shell) dependencies to align with `v2025.11.0` security patch and other dependency chain. --------- Co-authored-by: James George <[email protected]>
Co-authored-by: mirarifhasan <[email protected]> Co-authored-by: James George <[email protected]>
Fixes agent interceptor registration broken by dependency update --------- Co-authored-by: James George <[email protected]>
Co-authored-by: James George <[email protected]>
Co-authored-by: James George <[email protected]>
…5570) Co-authored-by: mirarifhasan <[email protected]> Co-authored-by: James George <[email protected]>
…ach tab (#5544) Co-authored-by: Nivedin <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: nivedin <[email protected]>
Follow up to #5590.
Co-authored-by: nivedin <[email protected]> Co-authored-by: James George <[email protected]>
…5448) Co-authored-by: Viraj <[email protected]> Co-authored-by: Anwarul Islam <[email protected]>
Refined network retry logic to distinguish between transient infrastructure
failures and intentional test errors, preventing incorrect test skips in
JUnit validation scenarios.
1. Network Error Detection (utils.ts)
- Renamed `hasNetworkError` → `hasLowLevelNetworkError` for clarity
- Removed REQUEST_ERROR from retry patterns (too generic, matches intentional bad URLs)
- Now only retries on unambiguous TCP/DNS errors: ECONNRESET, EAI_AGAIN,
ENOTFOUND, ETIMEDOUT, ECONNREFUSED
- Preserved TEST_SCRIPT_ERROR detection when concurrent with REQUEST_ERROR
(the actual CI failure mode from undefined response objects)
- Added comprehensive JSDoc explaining when to use vs plain runCLI
2. JUnit XML Validation (test.spec.ts, 4 locations)
- Removed REQUEST_ERROR and TEST_SCRIPT_ERROR from XML retry patterns
- Only retry when low-level errors corrupt XML structure
- Prevents skipping tests with intentional errors in collections
(test-junit-report-export-coll.json has intentional invalid-url and
script reference errors for validation)
3. Test Corrections
- Fixed: "Fails to display console logs..." test now uses plain runCLI
(test expects errors from legacy sandbox, shouldn't use retry)
- Added: Environment version tests (v0, v1, v2) now use runCLIWithNetworkRetry
(use echo.hoppscotch.io, expect success, benefit from retry)
- Removed: Obsolete SKIP_EXTERNAL_TESTS env var check (retry logic handles this)
Co-authored-by: mirarifhasan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )