FIX: ISXB-586 inputsystem sendpointerhovertoparent #1975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitalain
changed the title
Pauliusd01
requested changes
Aug 5, 2024
…nto isxb-586-inputsystemsendpointerhovertoparent # Conflicts: # Packages/com.unity.inputsystem/CHANGELOG.md # Packages/com.unity.inputsystem/InputSystem/Unity.InputSystem.asmdef
…nto isxb-586-inputsystemsendpointerhovertoparent # Conflicts: # Packages/com.unity.inputsystem/CHANGELOG.md
…nto isxb-586-inputsystemsendpointerhovertoparent # Conflicts: # Packages/com.unity.inputsystem/CHANGELOG.md # Packages/com.unity.inputsystem/InputSystem/Plugins/UI/InputSystemUIInputModule.cs
I believe all the errors are fixed now. |
Pauliusd01
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira ticket: https://jira.unity3d.com/browse/ISXB-586
Trunk PR: https://github.cds.internal.unity3d.com/unity/unity/pull/52658
Trunk PR needs to land first before this PR can be tested (and merged).
Changes made
Implements BaseInputModule sendPointerHoverToParent property for InputSystemUIInputModule. Also properly set PointerEventData reentered and fullyExited properties.
Testing
Manually tested the repro project with the fix. Added 6 unit tests (copied from the uGUI StandaloneInputModule-based tests).
Risk
Even though the changes are mostly copying the code from StandaloneInputModule, the changes are a bit interleaved with other new logic that only exists on the InputSystemUIInputModule side. The relation between those two classes is a bit of a mess (very little reuse of methods that have been put there in the spirit of being reused). I can't be entirely sure that this change is risk-free. I've tested the feature to a reasonable level, but I encourage any QA that knows uGUI more deeply to jump in.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: