Skip to content

Conversation

jamesmcgill
Copy link
Collaborator

Description

Re-enabling tests as they appear to be working with current Unity versions.

Changes made

Remove Ignore flag from 3 tests

Testing

Ran Playmode tests locally on U6

Risk

N/A

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@jamesmcgill jamesmcgill requested a review from ekcoh August 9, 2024 12:41
@jamesmcgill jamesmcgill changed the title CHANGE: Re-enable displayIndex related tests CHANGE: Re-enable displayIndex related tests (ISXB-935) Aug 9, 2024
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesmcgill jamesmcgill merged commit e1f069b into develop Aug 14, 2024
@jamesmcgill jamesmcgill deleted the ISXB-935-reenable-displayindex-tests branch August 14, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants