Skip to content

FIX: ISXB-1013-prevent-ui-update-loop #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 20, 2024
Merged

FIX: ISXB-1013-prevent-ui-update-loop #1984

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
95e0712
changelog entry
smnwttbr Aug 14, 2024
ee22064
Improve ui test CanRenameActionMap to take the scheduler in account
bmalrat Aug 14, 2024
c2728f5
Merge branch 'develop' into isxb-1013-update-loop-in-asset-editor
smnwttbr Aug 19, 2024
7f4d89d
updated changelog entry
smnwttbr Aug 19, 2024
be2d686
updated changelog entry
smnwttbr Aug 19, 2024
8515518
Merge branch 'develop' into isxb-1013-update-loop-in-asset-editor
bmalrat Aug 19, 2024
06908e9
Merge branch 'develop' into isxb-1013-update-loop-in-asset-editor
bmalrat Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ however, it has to be formatted properly to pass verification tests.
### Fixed
- Fixed memory allocation on every frame when using UIDocument without EventSystem. [ISXB-953](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-953)
- Fixed Action Maps name edition which could be inconsistent in Input Action Editor UI.
- Fixed an update loop in the asset editor.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest describing the symptom and the actual issue happening that was fixed here instead or what do you think?


### Added
- Added Hinge Angle sensor support for foldable devices.
Expand Down
5 changes: 0 additions & 5 deletions Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ActionsTreeView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,6 @@ public ActionsTreeView(VisualElement root, StateContainer stateContainer)
var item = m_ActionsTreeView.GetItemDataForIndex<ActionOrBindingData>(m_ActionsTreeView.selectedIndex);
Dispatch(item.isAction ? Commands.SelectAction(item.name) : Commands.SelectBinding(item.bindingIndex));
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is safe, the problem here is that there seem to be two related but separate concepts of selection, one in the UI model part of the UITK controls and one in the custom model part of this repo.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only worry is that when the number of actions goes down to zero, as in deleting the last action form a map, the UI might be without selection but the State model might have a selection so they are out of sync. I suspect the loop is due to the below commands when being handled by the UI code do not skip further processing if the UI model and this custom selection model are actually equal. E.g. that else should maybe be an else if checking if the selections are not in sync.

else
{
Dispatch(Commands.SelectAction(null));
Dispatch(Commands.SelectBinding(-1));
}
};

m_ActionsTreeView.RegisterCallback<ExecuteCommandEvent>(OnExecuteCommand);
Expand Down