-
Notifications
You must be signed in to change notification settings - Fork 329
CHANGE: enable performance test to be run continiously on U6 #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change required since we don't have a master
branch.
I'm ok with approving once that's fixed.
However, could just explain what's the goal with having this in CI? It's not clear to me.
More precisely, it's unclear to me what is the goal of running this performance jobs daily in case there are no changes to the package? Is the goal to test against different Editor patch versions ?
These test are currently almost never run on develop. Since nobody runs test on develop, except for me before a release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good update overall.
Description
This enables our current performance tests to be run continiously (daily on develop, weekly on master).
Changes made
Testing
Risk
Very little risk, all tests still run, no changes to the tests themselves.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: