-
Notifications
You must be signed in to change notification settings - Fork 328
CHANGE: Added message to notify the user if a PlayerInputComponent fails to bind a control scheme (ISXB-1020) #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ind a control scheme (ISXB-1020) This can happen if there are multiple game objects with PlayerInputComponent's and not enough devices to support them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still reproducing it with no error showing up, do I need to do anything extra or is this a proper issue?
1726740435.inputTest_-_GameplayScene_-_Windows._Mac._Linux_-_.mp4
That's the expected result when touchscreen and keyboard present, the error only shows when just keyboard present (i.e. only one valid control scheme that can be bound) |
Can you change it so it says "(all control schemes are already paired to matching devices)" or "(all control schemes are already paired to available devices)" to make it a bit more clear on what the issue is? Since I saw plenty of schemes to go around and it wasn't immediately obvious to me why I'd get this error as a user |
Minor message improvement
Done. |
Description
Added message to notify the user if a PlayerInputComponent fails to bind a control scheme (ISXB-1020)
This can happen if there are multiple game objects with PlayerInputComponent's and not enough devices to support them
Changes made
Added an error message in the case when the list of available control schemes has been exhausted
Testing
Ran on the test case in the bug report and it fires a message on PC when only a keyboard/mouse plugged in.
(Does not fire of a touchscreen is also connected)
Ran all the unit tests and they all pass
Risk
Potentially there is a use case I missed which doesn't warrant the error message
Checklist
Before review:
During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: