Skip to content

Conversation

lyndon-unity
Copy link
Collaborator

Description

Added message to notify the user if a PlayerInputComponent fails to bind a control scheme (ISXB-1020)
This can happen if there are multiple game objects with PlayerInputComponent's and not enough devices to support them

Changes made

Added an error message in the case when the list of available control schemes has been exhausted

Testing

Ran on the test case in the bug report and it fires a message on PC when only a keyboard/mouse plugged in.
(Does not fire of a touchscreen is also connected)

Ran all the unit tests and they all pass

Risk

Potentially there is a use case I missed which doesn't warrant the error message

Checklist

Before review:

  • Changelog entry added.
  • Ran existing tests
  • No new docs

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

…ind a control scheme (ISXB-1020)

This can happen if there are multiple game objects with PlayerInputComponent's and not enough devices to support them
@lyndon-unity lyndon-unity changed the title Added message to notify the user if a PlayerInputComponent fails to bind a control scheme (ISXB-1020) CHANGE: Added message to notify the user if a PlayerInputComponent fails to bind a control scheme (ISXB-1020) Sep 18, 2024
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still reproducing it with no error showing up, do I need to do anything extra or is this a proper issue?

1726740435.inputTest_-_GameplayScene_-_Windows._Mac._Linux_-_.mp4

@lyndon-unity
Copy link
Collaborator Author

I'm still reproducing it with no error showing up, do I need to do anything extra or is this a proper issue?

1726740435.inputTest_-GameplayScene-_Windows.Mac.Linux-.mp4

That's the expected result when touchscreen and keyboard present, the error only shows when just keyboard present (i.e. only one valid control scheme that can be bound)

@Pauliusd01
Copy link
Collaborator

Can you change it so it says "(all control schemes are already paired to matching devices)" or "(all control schemes are already paired to available devices)" to make it a bit more clear on what the issue is? Since I saw plenty of schemes to go around and it wasn't immediately obvious to me why I'd get this error as a user

Minor message improvement
@lyndon-unity
Copy link
Collaborator Author

lyndon-unity commented Sep 23, 2024

Can you change it so it says "(all control schemes are already paired to matching devices)" or "(all control schemes are already paired to available devices)" to make it a bit more clear on what the issue is? Since I saw plenty of schemes to go around and it wasn't immediately obvious to me why I'd get this error as a user

Done.
I've also switched from error to warning to match feedback from Hakan on a port of this change.

@Pauliusd01 Pauliusd01 self-requested a review September 23, 2024 10:20
@lyndon-unity lyndon-unity merged commit 1abc745 into develop Sep 24, 2024
77 checks passed
@lyndon-unity lyndon-unity deleted the isxb-1020-control-schemes-exhausted branch September 24, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants