NEW: Added canRunInBackground flag in device debug view #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmalrat
commented
Sep 25, 2024
| device.canRunInBackground; | ||
|
|
||
| // In editor, we may override canRunInBackground depending on the gameViewFocus setting. | ||
| #if UNITY_EDITOR |
There was a problem hiding this comment.
this code is already done in canRunInBackground
ekcoh
approved these changes
Sep 26, 2024
| - Changed representation of GamepadButton enum values in Inspector to display aliased enum values as a single item to avoid confusion around selection and aliased value display when multiple enum items map to the same numerical value. [ISXB-543](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-543) | ||
| - PlayerInput component now warns if the system cannot find matching control scheme, which can occur if all control schemes already paired (e.g. to other game objects with PlayerInput components) [ISXB-1020](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1020) | ||
| ### Added | ||
| - Added the display of the device flag CanRunInBackground in device debug view. |
There was a problem hiding this comment.
Minor: Code format CanRunInBackground
lyndon-unity
approved these changes
Sep 26, 2024
| // So, we modulate canRunInBackground depending on how input should behave WRT game view according | ||
| // to the input settings. | ||
| #if UNITY_EDITOR | ||
| #if UNITY_EDITOR |
There was a problem hiding this comment.
Personally I find this multi function spanning #if a bit hard to parse. Would love it if this could be simplified.
There was a problem hiding this comment.
Agree. From a readability perspective, it's not great. Can this be improved @bmalrat ?
jfreire-unity
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When investigation this issue https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-415 it was not possible to know that some device can run in back ground or not.
Changes made
Added an internal editor only property to be able to access to device flags without the editor override that would hide the device capability.
Testing
Tested locally on windows with ISXB-415 project + auto test
Risk
no change, only new internal api
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: