Skip to content

Conversation

jfreire-unity
Copy link
Collaborator

Description

Fixes ISXB-385

The problem in a nutshell:
image

Changes made

Set the correct bit field that maps to the equivalent "Select" button of Xbox controllers, the "View" button.

Testing

I tested with both Xbox wireless (Bluetooth capable) controllers. Both the Xbox One and Xbox Series S|X models.
It feels like the previous value didn't work for Xbox One wireless controllers so I'm not sure why that value was set in the first place. But maybe I just couldn't test with that device.
If there's a Xbox wireless controller that now doesn't work due to this change, let me know and I'll create a new class and state struct for it.

Risk

Untested Xbox wireless controllers stop working.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

Copy link
Collaborator

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If QA confirm its working I'm happy to approve

{
Start = 11,
Select = 16,
Select = 10,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very targetted fix, just needs some QA to verify.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did wonder - Should we still expose the 'share' button too?
Not needed to fix the issue but seems a little odd we don't expose it.

Copy link
Collaborator

@bmalrat bmalrat Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/mdqinc/SDL_GameControllerDB/blob/master/gamecontrollerdb.txt#L1094 it seems that it depends on the VID/PID of the device.
we might do some mapping in the native part or in c# if we can switch with the pid/vid

@jfreire-unity jfreire-unity removed the request for review from bmalrat September 27, 2024 16:29
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked Series X controller on Mac and & Windows for good measure in Editor and Playmode. The select button and others work correctly. Though I only had the newer xbox controller and didn't check xbox one

@jfreire-unity jfreire-unity merged commit d5f2dff into develop Oct 1, 2024
77 checks passed
@jfreire-unity jfreire-unity deleted the isxb-385-fix-wrong-xbox-gamepad-mapping-on-mac branch October 1, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants