Skip to content

Conversation

ekcoh
Copy link
Collaborator

@ekcoh ekcoh commented Oct 18, 2024

Description

Tentative fix for context menu issue in Input Action Editor.

Testing status & QA

Tested context menu when creating new input action asset on 6000.21f and 2022.3 latest LTS. Seem to give expected results.,

Overall Product Risks

One liner, small.

  • Complexity: Small
  • Halo Effect: Small

Comments to reviewers

The indirection used for context menus static helpers is confusing, good to have a second look on the change.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@ekcoh ekcoh requested review from Pauliusd01 and ritamerkl October 18, 2024 13:42
@ekcoh ekcoh changed the title Isxb 1134 menu fix FIX: ISXB-1134 Fix for Action context menu not showing on right-click. Oct 18, 2024
@ekcoh ekcoh marked this pull request as ready for review October 18, 2024 13:42
@ekcoh ekcoh requested review from bmalrat and removed request for ritamerkl October 18, 2024 15:34
Copy link
Collaborator

@ritamerkl ritamerkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unity-cla-assistant
Copy link

unity-cla-assistant commented Oct 23, 2024

CLA assistant check
All committers have signed the CLA.

@smnwttbr smnwttbr requested a review from bmalrat October 23, 2024 01:05
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked that ISXB-833 has not been reintroduced, tried adding maps and actions in various ways such as when the list is empty, when selecting different actions and maps, using the plus buttons, after undoing/redoing, etc (22.3.51 and U6 trunk)

Copy link
Collaborator

@bmalrat bmalrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@smnwttbr smnwttbr merged commit de8d662 into develop Oct 24, 2024
76 of 77 checks passed
@smnwttbr smnwttbr deleted the isxb-1134-menu-fix branch October 24, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants