Skip to content

fix: remove static libstdc++ linking on Linux to prevent potential crashes #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove static libstdc++ linking on Linux to prevent potential crashes #1080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Plugin~/CMakeLists.txt
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,9 @@ if(XCODE)
endif()
endif()

# Use lld linker instead of GNU ld. Link glibc++ statically because of
# compatibility of lower version of GLIBCXX. This package must support Ubuntu
# version 16.04, 18.04, 20.04.
# Use lld linker instead of GNU ld.
Copy link
Preview

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment should explain why lld linker is preferred over GNU ld to provide better context for future maintainers.

Suggested change
# Use lld linker instead of GNU ld.
# Use lld linker instead of GNU ld because lld provides significantly faster link times and better diagnostics,
# which improves developer productivity and reduces build times, especially for large projects.

Copilot uses AI. Check for mistakes.

if(Linux)
set(CMAKE_CXX_FLAG "${CMAKE_CXX_FLAG} -static-libstdc++")
add_link_options(-static-libstdc++ -fuse-ld=lld-11)
add_link_options(-fuse-ld=lld-11)
endif()

# enable debug output
Expand Down