Conversation
costinsin
reviewed
Feb 6, 2026
| git clone https://github.com/Universal-Commerce-Protocol/ucp.git | ||
| ``` | ||
|
|
||
| Then, run `npm run generate` pointing to the `spec` folder of the cloned |
Contributor
There was a problem hiding this comment.
nit: pointing to the source folder
| .extend( | ||
| CheckoutWithBuyerConsentCreateRequestSchema.pick({ buyer: true }).shape | ||
| ); | ||
| export const ExtendedCheckoutCreateRequestSchema = CheckoutSchema; |
Contributor
There was a problem hiding this comment.
Is this really necessary to export if it doesn't extend anything anymore?
| .extend( | ||
| CheckoutWithBuyerConsentUpdateRequestSchema.pick({ buyer: true }).shape | ||
| ); | ||
| export const ExtendedCheckoutUpdateRequestSchema = CheckoutSchema; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how checkout-related schemas are generated and used, simplifying the codebase and updating the schema generation process. The main changes include switching to a unified
CheckoutSchema, updating the schema generation script to use new JSON schema definitions, and updating documentation to reflect these changes.Schema usage and code simplification:
CheckoutWithFulfillmentResponseSchema,CheckoutWithDiscountCreateRequestSchema) with a single, unifiedCheckoutSchemathroughoutsrc/extensions.ts, significantly simplifying type composition and schema extension. [1] [2] [3]Schema generation process:
generate_models.shscript to usenpx quicktypeinstead ofquicktypedirectly, and switched to new JSON schema definitions and $defs for generating TypeScript types, aligning the generated models with the latest schema structure.Documentation:
README.mdto instruct users to generate models from theucp/sourcedirectory instead ofucp/spec, reflecting the new schema location.