docs: use fulfillment instead of shipping in order totals example#162
Open
misza-one wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Open
docs: use fulfillment instead of shipping in order totals example#162misza-one wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
misza-one wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The order capability example used "shipping" as a total type, but the Total Response schema enum defines it as "fulfillment". Updated the example to match the schema definition. Fixes Universal-Commerce-Protocol#63
48c419e to
d518e6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the order capability example to use
"fulfillment"instead of"shipping"in the totals array. The Total schema defines the type enum as: items_discount, subtotal, discount, fulfillment, tax, fee, total. The value shipping is not valid for totals.Single line change in docs/specification/order.md:
Note: Other "type": "shipping" occurrences in the codebase are in fulfillment.methods[].type context, which correctly references fulfillment_method.json (enum: shipping, pickup). Only this totals example was using the wrong value.
Fixes #63
Type of change
Checklist