Skip to content

refactor: remove verbose logging from user details batch loading #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janosbabik merged 8 commits into from
Feb 27, 2026
Merged

refactor: remove verbose logging from user details batch loading #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a41c31d
refactor: remove verbose logging from user details batch loading
janosbabik Feb 16, 2026
88c683b
Merge branch 'develop' into remove-verbose-user-fetch-log
janosbabik Feb 18, 2026
e6102b7
Merge branch 'develop' into remove-verbose-user-fetch-log
janosbabik Feb 19, 2026
d1ce2ad
Merge branch 'develop' into remove-verbose-user-fetch-log
janosbabik Feb 23, 2026
a876699
Merge branch 'develop' into remove-verbose-user-fetch-log
janosbabik Feb 24, 2026
8e08446
Merge branch 'develop' into remove-verbose-user-fetch-log
janosbabik Feb 25, 2026
d738b93
Merge branch 'develop' into remove-verbose-user-fetch-log
janosbabik Feb 26, 2026
1b6f8bb
Merge branch 'develop' into remove-verbose-user-fetch-log
janosbabik Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions apps/backend/src/loaders/BasicUserDetailsLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { logger } from '@user-office-software/duo-logger';
import DataLoader from 'dataloader';
import { inject, injectable } from 'tsyringe';

Expand All @@ -12,11 +11,6 @@ export default class BasicUserDetailsLoader {
) {}
batchLoader = new DataLoader(
async (keys: readonly number[]) => {
logger.logInfo(
`Inside batch loading function fetching the basic user details for user id(s) ${keys}`,
{}
);

const usersList = await this.userDataSource.getBasicUsersInfo(keys);
const result = keys.map((id) => {
return usersList?.find((user) => user.id === id);
Expand Down
6 changes: 0 additions & 6 deletions apps/backend/src/loaders/UsersLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { logger } from '@user-office-software/duo-logger';
import DataLoader from 'dataloader';
import { inject, injectable } from 'tsyringe';

Expand All @@ -12,11 +11,6 @@ export default class UsersLoader {
) {}
batchLoader = new DataLoader(
async (keys: readonly number[]) => {
logger.logInfo(
`Inside batch loading function fetching the user details for user id(s) ${keys}`,
{}
);

const usersList = await this.userDataSource.getUsersByUserNumbers(keys);
const result = keys.map((id) => {
return usersList?.find((user) => user.id === id);
Expand Down
Loading