feat: automatically open for editing the cloned sample#1366
Open
jekabs-karklins wants to merge 3 commits intodevelopfrom
Open
feat: automatically open for editing the cloned sample#1366jekabs-karklins wants to merge 3 commits intodevelopfrom
jekabs-karklins wants to merge 3 commits intodevelopfrom
Conversation
jekabs-karklins
requested review from
EdwardHaynes
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new feature that automatically opens for editing the cloned sample.
Motivation and Context
This change was necessary to improve the user experience by reducing the number of steps a user has to take to edit a cloned sample. It also feels like natural thing to open the cloned sample because user would want to do some modifications.
Changes
QuestionaryComponentSampleDeclaration.tsx, after cloning a sample, the cloned sample is automatically set as the selected sample for editing.SampleAuthorization.tsthat checks if the user is an officer and returns true if they are.