-
Notifications
You must be signed in to change notification settings - Fork 17
Added files for Pull request template #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
hi @sapatevaibhav @thedevyashsaini , by mistake i had linked the #28 also to this pull request , please consider this two also . |
Why are there changes in 7 files? |
As i had added the code for #28 in the same PR by Mistake |
if every thing looks good we can move forward @thedevyashsaini |
Hi @sapatevaibhav , i had added the template which ask to describe the PR , like which issue does it close , why are we need this changes , what changes included . are this changes tested ? any other notes . |
|
Hi @sapatevaibhav , i think its ready . please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, you have also merged #28, but your useFastSudo.ts
hook file is empty and also you are importing sudo.rs
in main file and using functions which are not implemented as your sudo.rs is empty.
@itspsychocoder i had pushed some changes take a look |
Closes #27 . please take a look around @thedevyashsaini @sapatevaibhav