Skip to content

Conversation

Adez017
Copy link
Contributor

@Adez017 Adez017 commented Jul 29, 2025

Closes #27 . please take a look around @thedevyashsaini @sapatevaibhav

@Adez017
Copy link
Contributor Author

Adez017 commented Jul 29, 2025

hi @sapatevaibhav @thedevyashsaini , by mistake i had linked the #28 also to this pull request , please consider this two also .
also @thedevyashsaini, there can be some tweaks in the code as i am not regular practitioner for typescript part , please verify first
before moving forward

@Adez017
Copy link
Contributor Author

Adez017 commented Jul 30, 2025

CC: @thedevyashsaini @sapatevaibhav

@thedevyashsaini
Copy link
Collaborator

Why are there changes in 7 files?

@Adez017
Copy link
Contributor Author

Adez017 commented Jul 31, 2025

Why are there changes in 7 files?

As i had added the code for #28 in the same PR by Mistake

@Adez017
Copy link
Contributor Author

Adez017 commented Aug 1, 2025

if every thing looks good we can move forward @thedevyashsaini

@sapatevaibhav
Copy link
Member

@Adez017 Can you change the description of this PR with some information regarding the changes, as well will recommend to separate the pull request template as GSSoC distributes scores upon MR's.
as well keep eye on #25

@Adez017
Copy link
Contributor Author

Adez017 commented Aug 2, 2025

@Adez017 Can you change the description of this PR with some information regarding the changes, as well will recommend to separate the pull request template as GSSoC distributes scores upon MR's. as well keep eye on #25

Hi @sapatevaibhav , i had added the template which ask to describe the PR , like which issue does it close , why are we need this changes , what changes included . are this changes tested ? any other notes .

@Adez017
Copy link
Contributor Author

Adez017 commented Aug 2, 2025

as well will recommend to separate the pull request template as GSSoC distributes scores upon MR's.
could you please elaborate it

@Adez017 Adez017 changed the title Create pull_request_template.md Added files for Pull request template Aug 5, 2025
@Adez017
Copy link
Contributor Author

Adez017 commented Aug 9, 2025

Hi @sapatevaibhav , i think its ready . please have a look

Copy link
Collaborator

@itspsychocoder itspsychocoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, you have also merged #28, but your useFastSudo.ts hook file is empty and also you are importing sudo.rs in main file and using functions which are not implemented as your sudo.rs is empty.

@Adez017
Copy link
Contributor Author

Adez017 commented Aug 29, 2025

@itspsychocoder i had pushed some changes take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Pull Request Template
4 participants