Open
Conversation
Previous CI and tox runs apparently lied. This is because tests run against the main branch upstream, and not against the source code. This generates false positives/negatives that are only found when a merge completes but spending time fixing it is not a priority as of now. Therefore the quickfix of adding the file back has been chosen.
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 79.29% 79.29%
=======================================
Files 7 7
Lines 594 594
Branches 108 108
=======================================
Hits 471 471
Misses 90 90
Partials 33 33 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Does not look like it but this should fix the CI. I tested it on a fork (had to point the URL to it): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous CI and tox runs apparently lied. This is because tests run against the main branch upstream, and not against the source code.
This generates false positives/negatives that are only found when a merge completes but spending time fixing it is not a priority as of now. Therefore the quickfix of adding the file back has been chosen.