Skip to content

chore(deps): bump very_good_analysis from 9.0.0 to 10.0.0 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erickzanardo merged 4 commits into from
Sep 23, 2025
Merged

chore(deps): bump very_good_analysis from 9.0.0 to 10.0.0 #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84f2948
chore(deps): bump very_good_analysis from 9.0.0 to 10.0.0
dependabot[bot] Sep 19, 2025
e764980
Merge branch 'main' into dependabot/pub/very_good_analysis-10.0.0
erickzanardo Sep 23, 2025
ab1634b
fixing analyzer issue
erickzanardo Sep 23, 2025
01565c9
tighen the vga version
erickzanardo Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions lib/src/command_runner/commands/handle_completion_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,9 @@ class HandleCompletionRequestCommand<T> extends Command<T> {
}

// Parse the completion level into completion suggestions
final completionResults = CompletionParser(
completionLevel: completionLevel,
).parse();

CompletionParser(completionLevel: completionLevel).parse()
// Render the completion suggestions
for (final completionResult in completionResults) {
runner.renderCompletionResult(completionResult);
}
.forEach(runner.renderCompletionResult);
} on Exception {
// Do not output any Exception here, since even error messages are
// interpreted as completion suggestions
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ dependencies:
dev_dependencies:
mocktail: ^1.0.4
test: ^1.25.8
very_good_analysis: ^9.0.0
very_good_analysis: ">=10.0.0 <11.0.0"
1 change: 0 additions & 1 deletion test/src/installer/completion_configuration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Not required for test files
// ignore_for_file: prefer_const_constructors

import 'dart:collection';
import 'dart:io';
Expand Down
5 changes: 0 additions & 5 deletions test/src/installer/completion_installation_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ void main() {
expect(configFile.existsSync(), true);

// Different format needed for matching cli output
// ignore: leading_newlines_in_multiline_strings
expect(configFile.readAsStringSync(), '''
\n## [very_good]
## Completion config for "very_good"
Expand Down Expand Up @@ -287,7 +286,6 @@ void main() {
installation.writeToShellConfigFile('very_good');

// Different format needed for matching cli output
// ignore: leading_newlines_in_multiline_strings
expect(rcFile.readAsStringSync(), '''
\n## [Completion]
## Completion scripts setup. Remove the following line to uninstall
Expand Down Expand Up @@ -435,7 +433,6 @@ void main() {
// rc fle includes one reference to the global config

// Different format needed for matching cli output
// ignore: leading_newlines_in_multiline_strings
expect(rcFile.readAsStringSync(), '''
\n## [Completion]
## Completion scripts setup. Remove the following line to uninstall
Expand All @@ -450,7 +447,6 @@ void main() {
);

// Different format needed for matching cli output
// ignore: leading_newlines_in_multiline_strings
expect(globalConfig.readAsStringSync(), '''
\n## [very_good]
## Completion config for "very_good"
Expand Down Expand Up @@ -491,7 +487,6 @@ void main() {
..install('not_good');

// Different format needed for matching cli output
// ignore: leading_newlines_in_multiline_strings
expect(bashProfile.readAsStringSync(), '''
\n## [Completion]
## Completion scripts setup. Remove the following line to uninstall
Expand Down