removed acceptEULA parameter support #1454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
force-pushed
the
removed-accept-eula
branch
5 times, most recently
from
f904b76 to
8c063d0
Compare
f41gh7
reviewed
Jul 5, 2025
| // otherwise backupmanager cannot be added to single/cluster version. | ||
| // https://victoriametrics.com/legal/esa/ | ||
| // +optional | ||
| AcceptEULA bool `json:"acceptEULA"` |
There was a problem hiding this comment.
I suggest to make it no-op first at VictoriaMetrics ent version. Operator could produce a warning for validation webhook and suggest a migration. And add eual flag as is.
It'll simplify management of resource and provide a straightforward path for operator version rollback.
There was a problem hiding this comment.
EULA is noop starting from v1.122.0:
Update Note 2: all the VictoriaMetrics Enterprise components: -eula command-line flag is skipped when validating VictoriaMetrics enterprise license. Instead, the -license or -licenseFile command-line flags must be used to provide a valid license key. See these docs for configuration examples.
AndrewChubatiuk
force-pushed
the
removed-accept-eula
branch
from
8c063d0 to
63c7e72
Compare
AndrewChubatiuk
force-pushed
the
removed-accept-eula
branch
from
63c7e72 to
f078cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1319