-
Notifications
You must be signed in to change notification settings - Fork 0
DT-385-sso-and-multi-tenancy-documentation #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughDocumentation restructured under Organization: RBAC content consolidated into roles and the standalone role-based-access-control page removed. New Settings subsection added (Company, Single Sign-On, Subscription). New Tenants and Usage and Limits pages introduced. Sidebar updated to match the new structure and removed obsolete top-level SSO and Multitenancy entries. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Admin as Admin User
participant UI as DataStream UI
participant IdP as Azure AD/Entra ID
participant Auth as Auth Service
participant RBAC as RBAC Engine
rect rgb(240,248,255)
note over Admin,UI: Configure Single Sign-On (SSO)
Admin->>UI: Navigate Organization › Settings › Single Sign-On
UI-->>Admin: Display SSO configuration panel
Admin->>UI: Provide IdP metadata / initiate setup
UI->>Auth: Save SSO settings
Auth-->>UI: Confirm configuration saved
end
rect rgb(245,255,240)
note over Admin,RBAC: Assign role to user (post-SSO)
Admin->>UI: Assign Role to User
UI->>RBAC: Update user-role mapping
RBAC-->>UI: Acknowledge update
end
rect rgb(255,248,240)
note over User,Auth: Login via SSO
participant User as End User
User->>UI: Access DataStream
UI->>Auth: Start SSO flow
Auth->>IdP: Redirect for authentication
IdP-->>Auth: Token / assertion
Auth->>RBAC: Resolve roles & permissions
RBAC-->>Auth: Effective permissions
Auth-->>UI: Session + claims
UI-->>User: Grant access based on permissions
end
sequenceDiagram
autonumber
participant Admin as Admin
participant UI as DataStream UI
participant RBAC as RBAC Engine
rect rgb(250,250,255)
note over Admin,RBAC: Create Custom Role
Admin->>UI: Open Roles › Create Custom Role
UI-->>Admin: Show Basic/Advanced permission selectors
Admin->>UI: Set role details + select permissions
UI->>RBAC: Create role with permissions
RBAC-->>UI: Role created
end
rect rgb(255,250,245)
note over Admin,RBAC: Modify/Delete Role
Admin->>UI: Edit or Delete role
UI->>RBAC: Validate usage/dependencies
RBAC-->>UI: Validation result (allow/block)
UI-->>Admin: Success or error with guidance
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (6)
📒 Files selected for processing (8)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
|
Docs Feature Deployment https://54bf5b8b.virtualmetric-docs.pages.dev |
Summary by CodeRabbit