feat(builder): improve types export and error handling#358
Closed
youngwinds wants to merge 1 commit intomainfrom
Closed
feat(builder): improve types export and error handling#358youngwinds wants to merge 1 commit intomainfrom
youngwinds wants to merge 1 commit intomainfrom
Conversation
- Export MeasureNodeBuilder and DimensionNodeBuilder for external use - Add validation and error handling to NodeBuilders - Add Zod validation in build() methods for type safety - Improve removeMeasure to return boolean for success/failure - Add setHierarchyType and setFormat to DimensionNodeBuilder - Add validation error tracking with getValidationErrors() This improves code quality by: 1. Making NodeBuilder classes publicly accessible 2. Adding runtime validation with helpful error messages 3. Ensuring type safety through Zod schema validation 4. Providing better developer experience with error tracking
Collaborator
Author
|
。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves code quality by:
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
☑️ Self-Check before Merge