feat(vquery): improve having integration tests#360
Open
youngwinds wants to merge 8 commits intomainfrom
Open
Conversation
added 8 commits
March 4, 2026 23:10
- Add aggregation integration tests (sum, avg, count, min, max) - Delete unit tests, use integration tests only - Fix _meta.json to include having directory - All 135 tests passing
- Fix having filter transformation format - Fix having.ts to use default switch instead of unreachable default case - Tests: 136 passed
- Add sum, avg, count, min, max operators to VBI HavingFilter - Add unit tests for having aggregation operators - Update HavingFilterNodeBuilder to support aggregation operators Tests: 141 passed
- Add is-null, is-not-null, between, not-between integration tests - Fix test cases to use aggregated fields in having clause - Tests: 145 passed - Coverage: 99.05% statements, 92.14% branches, 100% functions, 99.46% lines
Tests: 145 passed - Function coverage: 100% - Statement coverage: 89.18% - Note: rstest has known coverage tracking limitations for certain code patterns
- Add PeriodConfig type with dateField, offsetUnit, offset - Add OffsetUnit type (year/quarter/month/week/day) - Update SelectItem to support period config - Implement SQL generation for LAG window function Note: Integration tests need GROUP BY updates - will follow up
- Auto-add dateField from period config to GROUP BY - Add period-yoy integration test - Coverage: 96.71% statements
- Add MoM (month-over-month) integration test - Add QoQ (quarter-over-quarter) integration test - Tests: 148 passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
☑️ Self-Check before Merge