fix(core): duplicate static tools provided to llm #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 88ab6fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marinoska
force-pushed
the
fix-duplicate-static-tools
branch
4 times, most recently
from
3aa77d1 to
c3fa01b
Compare
marinoska
force-pushed
the
fix-duplicate-static-tools
branch
from
c3fa01b to
88ab6fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
When preparing agent execution, both static and dynamic tools are merged and passed to toolManager.prepareToolsForGeneration. This causes each tool (e.g., getWeather) to appear twice, since dynamic clones are added even for non-dynamic tools.
What is the new behavior?
Only dynamic tools should be passed to prepareToolsForGeneration
fixes (issue)
#668
Notes for reviewers