bip340 key tweaking #202
Merged
bip340 key tweaking #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgeihs
force-pushed
the
feat/bip340-key-tweak
branch
2 times, most recently
from
a207727 to
b589d24
Compare
matthiasgeihs
force-pushed
the
feat/bip340-key-tweak
branch
from
b589d24 to
ac353ad
Compare
matthiasgeihs
force-pushed
the
feat/bip340-key-tweak
branch
2 times, most recently
from
b97f09f to
ef224dd
Compare
- quick fix session time test - quick fix sync error - quick fix loginWithSFA return type
matthiasgeihs
force-pushed
the
feat/bip340-key-tweak
branch
from
ef224dd to
42db10e
Compare
himanshuchawla009
approved these changes
Dec 17, 2024
| } else if (this._sigType === "ed25519" || this._sigType === "bip340") { | ||
| return this.sign_frost(data, hashed); | ||
| if (opts?.hashed) { | ||
| throw CoreKitError.default(`hashed data not supported for bip340`); |
Member
There was a problem hiding this comment.
i think at this point we should streamline this hashed parameter, having it supported for one sig type and not for others increases integration and doc effort. Either we should drop the support of it completely or should make it consistent.
Happy to create a diff issue for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for bip340 key tweaking, as required for bip341 taproot transactions.
requires:
publish updated clientdeploy updated server