FAQ: Change asm2wasm to past tense#1403
Open
Artoria2e5 wants to merge 1 commit intoWebAssembly:mainfrom
Open
Conversation
binaryen has removed asm2wasm in version 97 (binaryen#3042), since Emscripten stopped using it. Use a fixed-version link to minimize confusion, and change to past tense for good measure.
kripken
reviewed
Mar 4, 2021
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
How about mentioning wasm2js, which has replaced asm2wasm in binaryen? It is basically a polyfill for wasm, and currently maintained & used in production. I'd suggest replacing the section on asm2wasm with that (unless we want to keep a mention of asm2wasm for historical reasons too).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
binaryen has removed asm2wasm in version 97 (WebAssembly/binaryen#3042), since Emscripten stopped using it. Use a fixed-version link to minimize confusion, and change to past tense for good measure.
The https://webassembly.org/getting-started/advanced-tools/ also has a reference to the same link. I think that's the website repo.