This repository was archived by the owner on Apr 25, 2025. It is now read-only.
[test] Unify the error message in type-subtyping.wast.#504
Open
q82419 wants to merge 1 commit intoWebAssembly:mainfrom
Open
[test] Unify the error message in type-subtyping.wast.#504q82419 wants to merge 1 commit intoWebAssembly:mainfrom
type-subtyping.wast.#504q82419 wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
Signed-off-by: YiYing He <yiying@secondstate.io>
rossberg
approved these changes
Jan 3, 2024
Member
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
I'm fine changing these, but wanted to point out that this and other message short forms were somewhat intentional, meant to make tests more robust with respect to fine-tuning of error messages in the interpreter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indirect call->indirect call type mismatchcast->cast failureincompatible import->incompatible import type