Fixing PAL and NTSC-U region issues and updated Touch! Generations#16
Open
Barcia04 wants to merge 7 commits intoWiiLink24:mainfrom
Open
Fixing PAL and NTSC-U region issues and updated Touch! Generations#16Barcia04 wants to merge 7 commits intoWiiLink24:mainfrom
Barcia04 wants to merge 7 commits intoWiiLink24:mainfrom
Conversation
…ect region Added country exclusive title ID code in order to fix DSiWare, and DSi games not appearing, and Wii, WiiWare, 3DS, and DS suffering the same in PAL regions. Added Special NTSC-U region, these regions are either Special Editiosn such as Walmart or Toys R' Us which they are blacklisted or Canadian releases. Some games (a small amount of them) are labeled wrong in GameTDB, these games are labeled as PAL instead of NTSC-U, so I added a code to force them to change to NTSC-U
Updated Touch Generations! IDs to include all region exclusive titles. Added variable to force titleIDs wrongly labeled to their correct region.
noahpistilli
requested changes
Feb 17, 2026
Member
noahpistilli
left a comment
noahpistilli
left a comment
There was a problem hiding this comment.
Please test your changes before making a pull request. As of right now these changes break everything.
Comment on lines
+178
to
+181
| "YBN", "VAAE", "VAAV", "AYA", "AND", "ANM", "ATD", "ADJ", "BET", "CNVP", "CNVF", "CNVD", "CNVI", "CNVS", "ANH", "ANG", "AUA", "AUB", "AUC", "AUD", "AUE", "AIX", "AIZ", | ||
| "YCU", "ATI", "AOS", "AG3", "AWIE", "APLE", "AJQE", "AJQJ","CM7", "BKCE", "ATG", "AVM", "AD5", "AD2", "ADG", "AD7", "AD3", "IMW", "IA8", "C6P", "AXP", "A4VJ", "AJM", "AOI" | ||
| "A8NE", "A2Y", "AZI", "ASQ", "AJY", "ATR", "ARJ", "AGFE", "USK", "VET", "YFCE" "YLZP", "YLZX", "YLZJ", "YNU", "SUPP", "SUPJ", "RFN", "RFP", "R64", "RYW", "RHAP", "RHAJ", | ||
| "RJT", "RSPP", "RSPJ", "RZTP", "RFBP", "R4EP", "RNOP", "RTYP", "SP2P", |
Member
There was a problem hiding this comment.
Where did you source these IDs from?
Author
There was a problem hiding this comment.
All these were sourced from different sources:
- Wikipedia which in itself is a bad source and was only used for reference since it had a huge list compared to other sites.
- By having some of these games which in the cover they do have the Touch! Generations logo.
- Nintendo Japan website for Wii and DS which suprisingly is still up.
- GameFAQs alongside GameTDB and Wikipedia by checking covers and if the list is correct.
- Old Touch! Generations page through Wayback Machine.
- Nintendo Europe page.
Comment on lines
+104
to
+107
| var regionToCodeTDB = map[constants.Region][]byte{ | ||
| constants.NTSC: {'E', 'L', 'X', 'Z'}, | ||
| constants.PAL: {'P', 'F', 'D', 'S', 'I', 'H', 'U', 'X', 'Y', 'V', 'Z'}, | ||
| constants.Japan: {'J'}, |
Member
There was a problem hiding this comment.
You changed the value of the map from byte to an array of byte, therefore you must alter all code that references this map to reflect the change.
Comment on lines
+164
to
+169
| forcedRegion := game.Region | ||
| isForced := slices.Contains(constants.CanadaUSAIDs, game.ID[:4]) | ||
|
|
||
| if isForced { | ||
| forcedRegion = "NTSC-U" | ||
| } |
Member
There was a problem hiding this comment.
This does literally nothing. forcedRegion is never used anywhere. Furthermore, since you only assign and never access forcedRegion, this won't even compile.
Attempted to fix region code that was badly implemented alongside the CanadaUSA IDs getting the ForceRegion implemented but not getting used.
Added missing commas in the Touch! Generation IDs causing syntax errors.
Added additional IDs to the CanadaUSAIDs list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INFO: