Open
Conversation
Member
|
I would rather just provide a named option, since it provides a simpler interface for users of the library. For example, you can already do |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rough patch that adds a constructor option for passing flags to
sqlite3_open_v2. This would enable several situations listed in #483, like using a URI, without needing a custom build.Relevant
SQLITE_OPEN_*constants are exposed throughDatabase.Constants(in case non-opening constants want to be exposed later).API feels weird, would like some feedback on that.
EDIT: forgot
SQLITE_OMIT_SHARED_CACHEremoves shared cache support, removing that reference...