Skip to content

Add option to remove taxonomy query from query block attributes #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Add option to remove taxonomy query from query block attributes #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fbad5d
Add option to remove taxonomy query from query block attributes (#734)
TremiDkhar Nov 4, 2024
4767014
Merge branch 'trunk' into issue-734/query-loop-filters-get-removed
pbking May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions includes/create-theme/theme-templates.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,9 @@ private static function eliminate_environment_specific_content_from_block( $bloc
}
}

// remove taxQuery attribute from query blocks
if ( 'core/query' === $block['blockName'] ) {
if ( isset( $block['attrs']['query']['taxQuery'] ) ) {
// (optionally) remove taxQuery attribute from query blocks
if ( 'core/query' === $block['blockName'] && isset( $block['attrs']['query']['taxQuery'] ) ) {
if ( ! $options || ( array_key_exists( 'removeTaxQuery', $options ) && $options['removeTaxQuery'] ) ) {
unset( $block['attrs']['query']['taxQuery'] );
}
}
Expand Down
19 changes: 19 additions & 0 deletions src/editor-sidebar/save-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export const SaveThemePanel = () => {
removeNavRefs: _preference?.removeNavRefs ?? false,
localizeText: _preference?.localizeText ?? false,
localizeImages: _preference?.localizeImages ?? false,
removeTaxQuery: _preference?.removeTaxQuery ?? false,
};
}, [] );

Expand Down Expand Up @@ -221,6 +222,24 @@ export const SaveThemePanel = () => {
}
onChange={ () => handleTogglePreference( 'removeNavRefs' ) }
/>
<CheckboxControl
__nextHasNoMarginBottom
label={ __(
'Remove Taxonomy Query',
'create-block-theme'
) }
help={ __(
'Remove the taxonomy query from the query loop block attributes.',
'create-block-theme'
) }
disabled={
! preference.saveTemplates && ! preference.savePatterns
}
checked={ preference.removeTaxQuery }
onChange={ () =>
handleTogglePreference( 'removeTaxQuery' )
}
/>
<Button
variant="primary"
icon={ archive }
Expand Down