[Website] Target temporary Playground in Import ZIP, Import from GitHub. Don't overwrite a saved site. #2990
+531
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing from GitHub or a ZIP file, we now ensure the import goes into a temporary Playground rather than overwriting a saved site. This protects saved sites from accidental data loss. For the GitHub import modal: Before showing the form, we check if the active site is saved. If so, we switch to an existing temporary site or create a new one. For ZIP import: When a file is selected while viewing a saved site, we store the file, switch to the temporary site, and then complete the import via a useEffect hook once the switch is complete. Added two e2e tests to verify: 1. Importing a ZIP while on a saved site switches to temporary site 2. Importing a ZIP when starting directly with a saved site slug creates a new temporary site for the import
adamziel
changed the title
…re-importing-data
…re-importing-data
adamziel
commented
Dec 6, 2025
| const crc32 = calculateCrc32(phpBytes); | ||
|
|
||
| // Build the ZIP file structure | ||
| const localFileHeader = Buffer.alloc(30 + filePathBytes.length); |
Collaborator
Author
There was a problem hiding this comment.
oh no, let's just use a library or a pre-made zip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that importing from GitHub or ZIP files always goes into a temporary Playground, protecting saved sites from accidental overwrite.
Test plan
?site-slug=<saved-site>(no temporary site exists)Two e2e tests have been added to verify this behavior automatically.