Refactor: Update PermissionedDomainDelete to use keylet for sle access #6063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6063 +/- ##
=======================================
Coverage 78.6% 78.6%
=======================================
Files 818 818
Lines 68989 68990 +1
Branches 8249 8236 -13
=======================================
+ Hits 54203 54217 +14
+ Misses 14786 14773 -13
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
reviewed
Nov 21, 2025
Comment on lines
-57
to
+58
| auto const ownerSle = view().peek(keylet::account(account_)); | ||
| auto const owner = (*slePd)[sfOwner]; | ||
| auto const ownerSle = view().peek(keylet::account(owner)); |
Collaborator
There was a problem hiding this comment.
Why the change here? They are already checked that they are the same in preclaim
Member
Author
There was a problem hiding this comment.
because it is more intuitive.
Future readers of this code will no longer need to check preclaim.
Collaborator
There was a problem hiding this comment.
Probably better to split it into another PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Refactor to explicitly use
keylet::permissionedDomaininPermissionedDomainDeleteprocessing.Context of Change
keylet::permissionedDomaininPermissionedDomainDeleteprocessing.Ownerfrom the pDomain'sOwnerfield instead of theAccountfield of the transaction. (This is a non-breaking change as these are checked to be the same value inpreclaim().)Type of Change