Skip to content

build(deps): bump bignumber.js from 9.1.2 to 9.3.0 #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

build(deps): bump bignumber.js from 9.1.2 to 9.3.0 #2988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc4d99a
build(deps): bump bignumber.js from 9.1.2 to 9.3.0
dependabot[bot] May 19, 2025
1766047
Merge branch 'main' into dependabot/npm_and_yarn/bignumber.js-9.3.0
khancode May 22, 2025
bf4500f
fix build error
pdp2121 Jun 3, 2025
e730020
use ?? instead
pdp2121 Jun 3, 2025
560e360
Merge branch 'main' into dependabot/npm_and_yarn/bignumber.js-9.3.0
pdp2121 Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions packages/xrpl/src/Wallet/signer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,10 @@ function getTransactionWithAllSigners(
* @returns 1 if left \> right, 0 if left = right, -1 if left \< right, and null if left or right are NaN.
*/
function compareSigners(left: Signer, right: Signer): number {
return addressToBigNumber(left.Signer.Account).comparedTo(
addressToBigNumber(right.Signer.Account),
return (
addressToBigNumber(left.Signer.Account).comparedTo(
addressToBigNumber(right.Signer.Account),
) ?? 0
)
}

Expand Down
2 changes: 1 addition & 1 deletion packages/xrpl/src/sugar/getOrderbook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function sortOffers(offers: BookOffer[]): BookOffer[] {
const qualityA = offerA.quality ?? 0
const qualityB = offerB.quality ?? 0

return new BigNumber(qualityA).comparedTo(qualityB)
return new BigNumber(qualityA).comparedTo(qualityB) ?? 0
})
}

Expand Down
Loading