Bloch Messiah decomposition from The Walrus #729
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
===========================================
- Coverage 98.33% 38.88% -59.46%
===========================================
Files 78 78
Lines 9603 9578 -25
===========================================
- Hits 9443 3724 -5719
- Misses 160 5854 +5694
... and 57 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
strawberryfields/decompositions.py
Outdated
|
|
||
| n = n // 2 | ||
| omega = sympmat(n) | ||
| if np.linalg.norm(np.transpose(S) @ omega @ S - omega) >= tol: |
There was a problem hiding this comment.
there is a is_symplectic function in the walrus that you can use directly here :)
There was a problem hiding this comment.
oh! comments on unmodified lines 🧐
(thanks for the suggestion, will do!)
NOTE: This PR is using thewalrus/main. DO NOT MERGE until there is a new release of The Walrus (don't forget to change the requirement files accordingly).
Context:
The current implementation of the Bloch-Messiah decomposition fails for degenerate symplectic matrices.
Description of the Change:
The Walrus included a new implementation of the Bloch-Messiah decomposition that solves the issue. This PR swaps the
SF implementation for the new improved implementation on TW.
Benefits:
Bloch-Messiah works for degenerate symplectic matrices.
Possible Drawbacks:
None.
Related GitHub Issues:
Closes #728